Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Use CollectionsMarshal.GetValueRefOrAddDefault to optimize adding to dictionaries - #6443

#6443
Merged
JamesNK merged 3 commits into
mainmicrosoft/aspire:mainfrom
jamesnk/dictionary-perfmicrosoft/aspire:jamesnk/dictionary-perfCopy head branch name to clipboard
Oct 23, 2024
Merged

Use CollectionsMarshal.GetValueRefOrAddDefault to optimize adding to dictionaries#6443
JamesNK merged 3 commits into
mainmicrosoft/aspire:mainfrom
jamesnk/dictionary-perfmicrosoft/aspire:jamesnk/dictionary-perfCopy head branch name to clipboard

Conversation

@JamesNK

@JamesNK JamesNK commented Oct 23, 2024

Copy link
Copy Markdown
Member

Description

Made a pass over dashboard code to see where CollectionsMarshal.GetValueRefOrAddDefault could be used. It skips the overhead of trying to find a value and then adding the value if missing.

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?
    • Yes
      • Link to aspire-docs issue:
    • No
Microsoft Reviewers: Open in CodeFlow

@JamesNK
JamesNK merged commit 0f3bccb into main Oct 23, 2024
@JamesNK
JamesNK deleted the jamesnk/dictionary-perf branch October 23, 2024 06:52
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.