Multi-target Aspire.Hosting.AppHost - #6440
#6440Merged
eerhardt merged 1 commit intoOct 23, 2024
microsoft:mainmicrosoft/aspire:mainfrom
eerhardt:ForwardPortMultiTargetingeerhardt/aspire:ForwardPortMultiTargetingCopy head branch name to clipboard
Merged
Multi-target Aspire.Hosting.AppHost#6440eerhardt merged 1 commit intomicrosoft:mainmicrosoft/aspire:mainfrom eerhardt:ForwardPortMultiTargetingeerhardt/aspire:ForwardPortMultiTargetingCopy head branch name to clipboard
eerhardt merged 1 commit into
microsoft:mainmicrosoft/aspire:mainfrom
eerhardt:ForwardPortMultiTargetingeerhardt/aspire:ForwardPortMultiTargetingCopy head branch name to clipboard
Conversation
Fix microsoft#6429 Also resolve PR feedback. Simplify how Http.Resilience version gets replaced in the templates.
radical
approved these changes
Oct 23, 2024
DamianEdwards
approved these changes
Oct 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This way both AppHost and AppHost Test projects get v9 MS.Ext.* packages when the projects target
net9.0. As it exists today, the AppHost project gets v8 MS.Ext.* packages when targetingnet9.0and the AppHost Test project gets v9 MS.Ext.* packages when targeting `net9.0Fix #6429
Also resolve PR feedback. Simplify how Http.Resilience version gets replaced in the templates.
Forward port changes from #6420
Checklist
Microsoft Reviewers: Open in CodeFlow