Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Set docker summaries for all extensions. - #6323

#6323
Merged
eerhardt merged 7 commits into
mainmicrosoft/aspire:mainfrom
sebros/summariesmicrosoft/aspire:sebros/summariesCopy head branch name to clipboard
Oct 22, 2024
Merged

Set docker summaries for all extensions.#6323
eerhardt merged 7 commits into
mainmicrosoft/aspire:mainfrom
sebros/summariesmicrosoft/aspire:sebros/summariesCopy head branch name to clipboard

Conversation

@sebastienros

@sebastienros sebastienros commented Oct 15, 2024 •
edited by dotnet-policy-service Bot
Loading

Copy link
Copy Markdown
Contributor

Description

Saw that it was missing on SqlServer during Damian's demo.

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?
    • Yes
      • Link to aspire-docs issue:
    • No
Microsoft Reviewers: Open in CodeFlow

@sebastienros
Set docker summaries for all extensions.
9bbd473 
Saw that it was missing on SqlServer during Damian's demo.
@davidfowl

davidfowl commented Oct 16, 2024

Copy link
Copy Markdown
Contributor

/azp run

@azure-pipelines

azure-pipelines Bot commented Oct 16, 2024

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@build-analysis build-analysis Bot mentioned this pull request Oct 16, 2024
Closed
2 tasks
@sebastienros
sebastienros requested a review from eerhardt October 16, 2024 17:18
eerhardt
eerhardt reviewed Oct 16, 2024
View reviewed changes
Comment thread src/Aspire.Hosting.Azure.CosmosDB/AzureCosmosDBExtensions.cs Outdated
eerhardt
eerhardt reviewed Oct 16, 2024
View reviewed changes
Comment thread src/Aspire.Hosting.Redis/RedisContainerImageTags.cs Outdated
@sebastienros
sebastienros requested a review from eerhardt October 22, 2024 18:48
eerhardt
eerhardt reviewed Oct 22, 2024
View reviewed changes
Comment thread src/Aspire.Hosting.MySql/MySqlBuilderExtensions.cs Outdated
eerhardt
eerhardt approved these changes Oct 22, 2024
View reviewed changes

@eerhardt eerhardt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eerhardt
eerhardt enabled auto-merge (squash) October 22, 2024 19:02
@eerhardt
eerhardt merged commit 69cabab into main Oct 22, 2024
@eerhardt
eerhardt deleted the sebros/summaries branch October 22, 2024 20:15
@sebastienros

sebastienros commented Oct 22, 2024

Copy link
Copy Markdown
Contributor Author

/backport to release/9.0

@github-actions

github-actions Bot commented Oct 22, 2024

Copy link
Copy Markdown
Contributor

Started backporting to release/9.0: https://github.com/dotnet/aspire/actions/runs/11468909812

@github-actions github-actions Bot mentioned this pull request Oct 22, 2024
Merged
@sebastienros

sebastienros commented Oct 22, 2024

Copy link
Copy Markdown
Contributor Author

@eerhardt As I was writing what validation I had just done to ensure it's working, I realized that moving it to <remarks> is actually breaking it. Because it will now "inherit" the remarks tags. So the /// <summary>latest</summary> on the tags now need to be in /// <remarks> too.

@eerhardt

eerhardt commented Oct 22, 2024

Copy link
Copy Markdown
Member

So the /// <summary>latest</summary> on the tags now need to be in /// <remarks> too.

You mean "instead of" right?

@sebastienros

sebastienros commented Oct 22, 2024

Copy link
Copy Markdown
Contributor Author

"too" because I changed summary to remarks, so the Tags also need the change. But yes.
I applied the change on the backport PR, assuming we can then merge release/9.0 back to main. Not sure we need to update it in main in that case.

@davidfowl

davidfowl commented Oct 22, 2024

Copy link
Copy Markdown
Contributor

backport?

@eerhardt

eerhardt commented Oct 22, 2024

Copy link
Copy Markdown
Member

backport?

#6433

@github-actions github-actions Bot locked and limited conversation to collaborators Nov 22, 2024
@github-actions github-actions Bot added the area-integrations Issues pertaining to Aspire Integrations packages label Mar 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@eerhardt eerhardt eerhardt approved these changes

Assignees

No one assigned

Labels

area-integrations Issues pertaining to Aspire Integrations packages

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sebastienros @davidfowl @eerhardt
Morty Proxy This is a proxified and sanitized view of the page, visit original site.