Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Support reference expressions and endpoint references in WithParameter - #5491

#5491
Merged
davidfowl merged 1 commit into
mainmicrosoft/aspire:mainfrom
davidfowl/with-parameter-overloadsmicrosoft/aspire:davidfowl/with-parameter-overloadsCopy head branch name to clipboard
Aug 30, 2024
Merged

Support reference expressions and endpoint references in WithParameter#5491
davidfowl merged 1 commit into
mainmicrosoft/aspire:mainfrom
davidfowl/with-parameter-overloadsmicrosoft/aspire:davidfowl/with-parameter-overloadsCopy head branch name to clipboard

Conversation

@davidfowl

@davidfowl davidfowl commented Aug 30, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes #4060

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?
    • Yes
      • Link to aspire-docs issue:
    • No

@davidfowl
davidfowl requested a review from mitchdenny August 30, 2024 05:05
@ghost ghost added the area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication label Aug 30, 2024
@build-analysis build-analysis Bot mentioned this pull request Aug 30, 2024
Closed
@davidfowl

davidfowl commented Aug 30, 2024

Copy link
Copy Markdown
Contributor Author

/azp run

@azure-pipelines

azure-pipelines Bot commented Aug 30, 2024

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@davidfowl
davidfowl requested a review from eerhardt August 30, 2024 19:57
eerhardt
eerhardt approved these changes Aug 30, 2024
View reviewed changes

@eerhardt eerhardt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@davidfowl
davidfowl merged commit c973ace into main Aug 30, 2024
@davidfowl
davidfowl deleted the davidfowl/with-parameter-overloads branch August 30, 2024 21:46
@github-actions github-actions Bot locked and limited conversation to collaborators Sep 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@eerhardt eerhardt eerhardt approved these changes
@mitchdenny mitchdenny Awaiting requested review from mitchdenny mitchdenny is a code owner

Assignees

No one assigned

Labels

area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add overloads to AzureResourceExtensions.WithParameter

2 participants

@davidfowl @eerhardt
Morty Proxy This is a proxified and sanitized view of the page, visit original site.