Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Branding changes for 9.0 - #5400

#5400
Merged
joperezr merged 1 commit into
mainmicrosoft/aspire:mainfrom
joperezr-patch-1microsoft/aspire:joperezr-patch-1Copy head branch name to clipboard
Aug 26, 2024
Merged

Branding changes for 9.0#5400
joperezr merged 1 commit into
mainmicrosoft/aspire:mainfrom
joperezr-patch-1microsoft/aspire:joperezr-patch-1Copy head branch name to clipboard

Conversation

@joperezr

@joperezr joperezr commented Aug 23, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

Description

Now that release/8.2 has snapped, making branding changes for 9.0

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?
    • Yes
      • Link to aspire-docs issue:
    • No
Microsoft Reviewers: Open in CodeFlow

@joperezr
joperezr requested review from eerhardt and radical August 23, 2024 15:27
@ghost ghost added the area-codeflow for labeling automated codeflow. intentionally a different color! label Aug 23, 2024
@joperezr
joperezr enabled auto-merge (squash) August 23, 2024 15:47
@joperezr

joperezr commented Aug 23, 2024

Copy link
Copy Markdown
Member Author

/azp run dotnet.aspire

@azure-pipelines

azure-pipelines Bot commented Aug 23, 2024

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

eerhardt
eerhardt approved these changes Aug 26, 2024
View reviewed changes
Comment thread eng/Versions.props
<MinorVersion>0</MinorVersion>
<PatchVersion>0</PatchVersion>
<VersionPrefix>8.2.0</VersionPrefix>
<VersionPrefix>9.0.0</VersionPrefix>

@eerhardt eerhardt Aug 26, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why isn't this?

Suggested change
<VersionPrefix>9.0.0</VersionPrefix>
<VersionPrefix>$(MajorVersion).$(MinorVersion).$(PatchVersion)</VersionPrefix>

@eerhardt eerhardt Aug 26, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ugh, auto-merge. Followed up in #5443.

@joperezr
joperezr merged commit 9757b4f into main Aug 26, 2024
@joperezr
joperezr deleted the joperezr-patch-1 branch August 26, 2024 16:49
@eerhardt eerhardt mentioned this pull request Aug 26, 2024
Merged
@github-actions github-actions Bot locked and limited conversation to collaborators Sep 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@eerhardt eerhardt eerhardt approved these changes
@radical radical Awaiting requested review from radical

Assignees

No one assigned

Labels

area-codeflow for labeling automated codeflow. intentionally a different color!

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@joperezr @eerhardt
Morty Proxy This is a proxified and sanitized view of the page, visit original site.