[release/13.0] Fix subscription ID not being disabled on Azure provisioning dialog - #12913
#12913Merged
joperezr merged 2 commits intoNov 21, 2025
release/13.0microsoft/aspire:release/13.0from
backport/pr-12888-to-release/13.0microsoft/aspire:backport/pr-12888-to-release/13.0Copy head branch name to clipboard
Merged
[release/13.0] Fix subscription ID not being disabled on Azure provisioning dialog#12913joperezr merged 2 commits intorelease/13.0microsoft/aspire:release/13.0from backport/pr-12888-to-release/13.0microsoft/aspire:backport/pr-12888-to-release/13.0Copy head branch name to clipboard
joperezr merged 2 commits into
release/13.0microsoft/aspire:release/13.0from
backport/pr-12888-to-release/13.0microsoft/aspire:backport/pr-12888-to-release/13.0Copy head branch name to clipboard
Conversation
github-actions
Bot
requested review from
captainsafia and
eerhardt
as code owners
November 11, 2025 23:54
Contributor
Author
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 12913Or
iex "& { $(irm https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 12913" |
davidfowl
approved these changes
Nov 12, 2025
joperezr
approved these changes
Nov 20, 2025
joperezr
left a comment
Member
There was a problem hiding this comment.
Regression and scoped fix. Approved. Should we add a test here too?
Member
|
Discussed yesterday. Tests will be added in main. |
This was referenced Nov 26, 2025
Merged
Merged
This was referenced Dec 19, 2025
Closed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #12888 to release/13.0
/cc @JamesNK
Customer Impact
There are some bugs on the Azure provisioning dialog:
Azure:SubscriptionIdin their config then the Azure provisioning dialog is broken. Subscription locations are never loaded and can't be selected. Major impact.Azure:SubscriptionIdin their config then the "Subscription Id" input is enabled before values are loaded into it by a tenant being selected. Minor impact.Testing
Manual testing
Risk
Low
Regression?
Yes, this regressed in 13 when tenant selection was added to the dialog.