[release/9.4] Backport a fix to add .dotnet to PATH on windows - #10540
#10540[release/9.4] Backport a fix to add .dotnet to PATH on windows#10540joperezr merged 1 commit intomicrosoft:release/9.4microsoft/aspire:release/9.4from radical:backport-dotnet-fix-9.4radical/aspire:backport-dotnet-fix-9.4Copy head branch name to clipboard
.dotnet to PATH on windows#10540Conversation
This was originally a part of microsoft#9868, and the fix stands on its own. ----- Try setting the PATH in a os-aware way (cherry picked from commit 08a4b70)
There was a problem hiding this comment.
Pull Request Overview
This PR backports a fix to ensure that the .dotnet directory is properly added to the PATH environment variable on Windows systems in the GitHub Actions workflow. The change addresses a platform-specific issue where the dotnet runtime wasn't being correctly resolved during test execution.
Key changes:
- Adds
.dotnetdirectory to PATH for both Linux/macOS and Windows environments - Ensures tests consistently use the restored dotnet runtime rather than system dotnet
- Uses OS-appropriate PATH variable syntax (
$GITHUB_PATHvs$env:GITHUB_PATH)
|
Probably a dump question, but why not just root's dotnet.cmd? It is exactly for that purpose after all. |
The issue I was running into was scenarios where we launched |
ahh, that makes sense. Thanks for clarifying. |
This was originally a part of #9868, and the fix stands on its own.
Try setting the PATH in a os-aware way
(cherry picked from commit 08a4b70)
cc @joperezr @captainsafia
Customer Impact
Testing
Risk
Regression?