Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

fix(documentation): make mobile sidebar dismissible - #3619

#3619
Open
praffiii wants to merge 1 commit into
microsoft:v2microsoft/TypeScript-Website:v2from
praffiii:prafficoding/make-the-mobile-documentation-sidebar-dismissiblepraffiii/TypeScript-Website:prafficoding/make-the-mobile-documentation-sidebar-dismissibleCopy head branch name to clipboard
Open

fix(documentation): make mobile sidebar dismissible#3619
praffiii wants to merge 1 commit into
microsoft:v2microsoft/TypeScript-Website:v2from
praffiii:prafficoding/make-the-mobile-documentation-sidebar-dismissiblepraffiii/TypeScript-Website:prafficoding/make-the-mobile-documentation-sidebar-dismissibleCopy head branch name to clipboard

Conversation

@praffiii

Copy link
Copy Markdown

Summary

Makes the mobile documentation sidebar fully dismissible while preserving its existing design, animation, and desktop behavior.

What

  • Adds dismissal through the hamburger trigger, backdrop, navigation links, and Escape.
  • Restores focus to the hamburger trigger after dismissal.
  • Exposes the drawer state with accurate accessible attributes and labels.
  • Prevents interaction and scrolling behind the open drawer while keeping the sidebar scrollable.
  • Safely handles Escape when the playground samples popover is absent.
  • Adds focused mobile and desktop regression coverage.

Why

The reason I made these changes is that navigating the documentation becomes difficult when I split my screen between the browser and my IDE.

Validation

  • pnpm --filter=typescriptlang-org test
  • pnpm test
  • Manually tested at 390×844 in Helium:
    • trigger, backdrop, navigation-link, and Escape dismissal
    • focus restoration and accessible state
    • background interaction and scroll locking
    • independently scrollable sidebar
    • mobile-to-desktop and desktop-to-mobile resizing
    • repeated open/close cycles with no runtime errors

@praffiii

Copy link
Copy Markdown
Author

@microsoft-github-policy-service agree

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Morty Proxy This is a proxified and sanitized view of the page, visit original site.