Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Type-only imports and exports#792

Merged
sheetalkamat merged 4 commits into
microsoft:mastermicrosoft/TypeScript-TmLanguage:masterfrom
andrewbranch:type-only-importsandrewbranch/TypeScript-TmLanguage:type-only-importsCopy head branch name to clipboard
Jan 7, 2020
Merged

Type-only imports and exports#792
sheetalkamat merged 4 commits into
microsoft:mastermicrosoft/TypeScript-TmLanguage:masterfrom
andrewbranch:type-only-importsandrewbranch/TypeScript-TmLanguage:type-only-importsCopy head branch name to clipboard

Conversation

@andrewbranch
Copy link
Copy Markdown
Member

Counterpart of microsoft/TypeScript#35200. Do not merge until that one has been.

Warning: my RegExp-fu is middling at best. This produces correct results for the cases I tested, but experts should review with scrutiny 😁

Comment thread tests/baselines/exportDeclarations.baseline.txt Outdated
@sheetalkamat
Copy link
Copy Markdown
Member

@andrewbranch I pushed a change to this that matches type locally instead of having to do look behind..

@sheetalkamat sheetalkamat merged commit 1632051 into microsoft:master Jan 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.