Fix const type parameters in TSX#1073
Open
phryneas wants to merge 1 commit into
microsoft:mastermicrosoft/TypeScript-TmLanguage:masterfrom
phryneas:pr/fix-constTypeParameter-in-tsxphryneas/TypeScript-TmLanguage:pr/fix-constTypeParameter-in-tsxCopy head branch name to clipboard
Open
Fix const type parameters in TSX#1073phryneas wants to merge 1 commit intomicrosoft:mastermicrosoft/TypeScript-TmLanguage:masterfrom phryneas:pr/fix-constTypeParameter-in-tsxphryneas/TypeScript-TmLanguage:pr/fix-constTypeParameter-in-tsxCopy head branch name to clipboard
phryneas wants to merge 1 commit into
microsoft:mastermicrosoft/TypeScript-TmLanguage:masterfrom
phryneas:pr/fix-constTypeParameter-in-tsxphryneas/TypeScript-TmLanguage:pr/fix-constTypeParameter-in-tsxCopy head branch name to clipboard
Conversation
phryneas
commented
May 18, 2026
| @@ -1,4 +1,3 @@ | ||
| // @onlyOwnGrammar - this has type parameters that would be jsx in tsx files |
Author
There was a problem hiding this comment.
This test now works with both ts and tsx
phryneas
commented
May 18, 2026
| foo<const U>(x: U) { return x; } | ||
| } | ||
| const C2 = class <const T> {} | ||
| const fx1 = <const T>(x: T) => x; |
Author
There was a problem hiding this comment.
This line is ambiguous in tsx - moved into a separate test
phryneas
commented
May 18, 2026
| source.ts meta.var.expr.ts meta.class.ts punctuation.definition.block.ts | ||
| ^ | ||
| source.ts meta.var.expr.ts meta.class.ts punctuation.definition.block.ts | ||
| >const fx1 = <const T>(x: T) => x; |
Author
There was a problem hiding this comment.
This just moved to the other file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #979
I tried to reuse existing tests as far as possible - this should finally fix synax highlighing for
<const Foo extends Bar>kind type parameters.