Improve WebAssembly.instantiateStreaming#756
Merged
orta merged 1 commit intoSep 23, 2019
microsoft:mastermicrosoft/TypeScript-DOM-lib-generator:masterfrom
RReverser:improve-wasm-imports-exportsRReverser/TSJS-lib-generator:improve-wasm-imports-exportsCopy head branch name to clipboard
Merged
Improve WebAssembly.instantiateStreaming#756orta merged 1 commit intomicrosoft:mastermicrosoft/TypeScript-DOM-lib-generator:masterfrom RReverser:improve-wasm-imports-exportsRReverser/TSJS-lib-generator:improve-wasm-imports-exportsCopy head branch name to clipboard
orta merged 1 commit into
microsoft:mastermicrosoft/TypeScript-DOM-lib-generator:masterfrom
RReverser:improve-wasm-imports-exportsRReverser/TSJS-lib-generator:improve-wasm-imports-exportsCopy head branch name to clipboard
Conversation
Follow-up to microsoft#755.
Contributor
Author
|
@orta Apologies, this should be the last one. |
Contributor
|
👍 |
Contributor
Author
Contributor
|
Hrm, it looks to me like these changes are then PR'd into the TypeScript repo (maybe this was the last PR doing that - microsoft/TypeScript#32335 ) |
Contributor
Author
|
@orta I see. Do you want / need to do that as a maintainer, or should I? |
Contributor
Author
|
@orta Sorry, but ping :) Should I do something next? |
Contributor
|
Yep, I’d recommend sending a change over to the main repo - otherwise it’ll happen whenever we do an update ourselves |
sandersn
pushed a commit
to microsoft/TypeScript
that referenced
this pull request
Oct 14, 2019
This bumps generated bindings to include microsoft/TypeScript-DOM-lib-generator#767. Note that other related APIs were already updated in microsoft/TypeScript-DOM-lib-generator#755 and microsoft/TypeScript-DOM-lib-generator#756 and included in current TypeScript beta. Unfortunately, this one slipped under the radar, but it would be really great to include these changes in beta too for consistency between different WebAssembly methods.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #755.