Protected constructors accessible in subclass static methods#9904
Merged
sandersn merged 3 commits intoJul 25, 2016
mastermicrosoft/TypeScript:masterfrom
protected-constructors-accessible-in-subclass-static-methodsmicrosoft/TypeScript:protected-constructors-accessible-in-subclass-static-methodsCopy head branch name to clipboard
Merged
Protected constructors accessible in subclass static methods#9904sandersn merged 3 commits intomastermicrosoft/TypeScript:masterfrom protected-constructors-accessible-in-subclass-static-methodsmicrosoft/TypeScript:protected-constructors-accessible-in-subclass-static-methodsCopy head branch name to clipboard
sandersn merged 3 commits into
mastermicrosoft/TypeScript:masterfrom
protected-constructors-accessible-in-subclass-static-methodsmicrosoft/TypeScript:protected-constructors-accessible-in-subclass-static-methodsCopy head branch name to clipboard
Conversation
in static methods of subclasses
Previously, it was an error to refer to a protected constructor from a base class, even in a static method where the semantics work. Now it is not an error in static methods.
| if (baseTypes.length) { | ||
| const baseType = baseTypes[0]; | ||
| if (containingFunction && | ||
| containingFunction.flags & NodeFlags.Static && |
Member
There was a problem hiding this comment.
Why does it matter whether the function is static?
Member
Author
There was a problem hiding this comment.
Oops. I wasn't paying attention and overfit to the example. I see that instance methods should be ok based on your constructor-with-super equivalence example.
Member
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9734