Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Fix 8482: Add Object.values and Object.entries #8538

Merged
yuit merged 9 commits into
mastermicrosoft/TypeScript:masterfrom
fix8482microsoft/TypeScript:fix8482Copy head branch name to clipboard
May 10, 2016
Merged

Fix 8482: Add Object.values and Object.entries #8538
yuit merged 9 commits into
mastermicrosoft/TypeScript:masterfrom
fix8482microsoft/TypeScript:fix8482Copy head branch name to clipboard

Conversation

@yuit

@yuit yuit commented May 9, 2016

Copy link
Copy Markdown
Contributor

Fix #8482

@mhegazy

mhegazy commented May 9, 2016

Copy link
Copy Markdown
Contributor

should we add lib.es2017.d.ts?

@yuit

yuit commented May 9, 2016

Copy link
Copy Markdown
Contributor Author

@mhegazy we probably should but then I think we should add target es2017 then?

@mhegazy

mhegazy commented May 10, 2016

Copy link
Copy Markdown
Contributor

we do not have an es2016 target yet.

@mhegazy

mhegazy commented May 10, 2016

Copy link
Copy Markdown
Contributor

👍

@@ -0,0 +1,9 @@
// @target: es6

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

// @lib: ess6,es2017.object would make this file compile without errors, right?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep!

@sandersn

Copy link
Copy Markdown
Member

👍 after adding a test case

@yuit yuit merged commit b68e939 into master May 10, 2016
@yuit yuit deleted the fix8482 branch May 10, 2016 21:22
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.