Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Add a test for optional members completions within an object within an index signature constraint#52149

Merged
andrewbranch merged 1 commit into
microsoft:mainmicrosoft/TypeScript:mainfrom
Andarist:tests/completions-index-signature-constraintAndarist/TypeScript:tests/completions-index-signature-constraintCopy head branch name to clipboard
Jan 9, 2023
Merged

Add a test for optional members completions within an object within an index signature constraint#52149
andrewbranch merged 1 commit into
microsoft:mainmicrosoft/TypeScript:mainfrom
Andarist:tests/completions-index-signature-constraintAndarist/TypeScript:tests/completions-index-signature-constraintCopy head branch name to clipboard

Conversation

@Andarist

@Andarist Andarist commented Jan 8, 2023

Copy link
Copy Markdown
Contributor

closes #9900

this is a test case from #9900 where the issue was fixed by #34855 . Since the fixing PR didn't include a test like this, I decided to PR this one, cc @andrewbranch

@typescript-bot typescript-bot added the For Backlog Bug PRs that fix a backlog bug label Jan 8, 2023

@andrewbranch andrewbranch left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@andrewbranch andrewbranch merged commit f326cbf into microsoft:main Jan 9, 2023
@Andarist Andarist deleted the tests/completions-index-signature-constraint branch January 9, 2023 19:34
@microsoft microsoft locked as resolved and limited conversation to collaborators Oct 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

For Backlog Bug PRs that fix a backlog bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TS losing optional properties when used with index signature and generics

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.