Make Collection and ReadonlyCollection internal#51964
Merged
Merged
Make Collection and ReadonlyCollection internal#51964
Conversation
Member
|
Could you document these in https://github.com/microsoft/TypeScript/wiki/API-Breaking-Changes if necessary? |
Member
Author
|
Yes, of course. |
sandersn
approved these changes
Jan 5, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #51439; these types were declared next to our
MapandSettypes, but these types are not actually used in our public API, only in a very small number of internal ones.I don't think there's a major reason to have these in our public API, and given we've removed Map/Set (which were a part of other public APIs), now seems like a good time to drop these.
I did try removing them entirely, but doing that turned out to be tricky in a couple of places. It's probably worth reevaluating if/when we start using native iterator helpers.