Emit leading comments for '}' of function/constructor block#509
Merged
sheetalkamat merged 2 commits intoAug 22, 2014
mastermicrosoft/TypeScript:masterfrom
emitLeadingCommentsForCurlymicrosoft/TypeScript:emitLeadingCommentsForCurlyCopy head branch name to clipboard
Merged
Emit leading comments for '}' of function/constructor block#509sheetalkamat merged 2 commits intomastermicrosoft/TypeScript:masterfrom emitLeadingCommentsForCurlymicrosoft/TypeScript:emitLeadingCommentsForCurlyCopy head branch name to clipboard
sheetalkamat merged 2 commits into
mastermicrosoft/TypeScript:masterfrom
emitLeadingCommentsForCurlymicrosoft/TypeScript:emitLeadingCommentsForCurlyCopy head branch name to clipboard
Conversation
Contributor
|
I assume this will be done for all blocks in a later checkin? |
Member
Author
|
old compiler did this only for function/constructor block so I did this only for function/constructor blocks |
Contributor
|
👍 |
Contributor
|
we should not be following hte old compiler. It was adhoc and did things incorrectly. We should be preserving as much of the comment structure that we can. The only times when we really might not preserve a comment are when we truly don't know how to. For example, if the comment is in code that we aren't even emitting (i.e. like inside an interface). |
sheetalkamat
added a commit
that referenced
this pull request
Aug 22, 2014
Emit leading comments for '}' of function/constructor block
Member
Author
|
Will file separate issue for handling such cases, but right now we should first get to parity of old compiler. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.