Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Update Visual Studio Code ignores#4760

Merged
mhegazy merged 2 commits into
microsoft:mastermicrosoft/TypeScript:masterfrom
Eyas:vscode-ignoresEyas/TypeScript:vscode-ignoresCopy head branch name to clipboard
Sep 28, 2015
Merged

Update Visual Studio Code ignores#4760
mhegazy merged 2 commits into
microsoft:mastermicrosoft/TypeScript:masterfrom
Eyas:vscode-ignoresEyas/TypeScript:vscode-ignoresCopy head branch name to clipboard

Conversation

@Eyas

@Eyas Eyas commented Sep 13, 2015

Copy link
Copy Markdown
Contributor

In Visual Studio Code 0.8.0, .settings is renamed to .vscode; adds .vscode ignores to .gitignore with an override for tasks.json per #3156.

Rename of .settings to .vscode is introduced in #4739.

@msftclas

msftclas commented Sep 13, 2015

Copy link
Copy Markdown

Hi @Eyas, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
We will now validate the agreement and then real humans will evaluate your PR.

TTYL, MSBOT;

@DanielRosenwasser

DanielRosenwasser commented Sep 13, 2015

Copy link
Copy Markdown
Member

Thanks for the PR @Eyas, can you remove the lines for .settings too?

@Eyas

Eyas commented Sep 13, 2015

Copy link
Copy Markdown
Contributor Author

I was considering that. I know that some editors/IDEs do have a .settings folder (eclipse being the main one). the .settings .gitignore line was added before 721b70f (the vscode commit). Should I perhaps just remove !.settings/tasks.json line, or go ahead and remove references to both?

@DanielRosenwasser

DanielRosenwasser commented Sep 13, 2015

Copy link
Copy Markdown
Member

I guess keep .settings in that case, and remove the line on .settings/tasks.json.

Eyas added 2 commits September 13, 2015 13:05
@Eyas
Update Visual Studio Code ignores
50c4c7a 
In Visual Studio Code 0.8.0, .settings is renamed to .vscode; adds
.vscode ignores to .gitignore with an override for tasks.json per microsoft#3156,
and removes vscode override for .settings
@Eyas
Also ignore .vscode from .npmignore
c43754f
@Eyas

Eyas commented Sep 13, 2015

Copy link
Copy Markdown
Contributor Author

Thanks; just did.

@DanielRosenwasser

DanielRosenwasser commented Sep 28, 2015

Copy link
Copy Markdown
Member

Hey @Eyas sorry this fell off my radar. @weswigham has fixed up our .npmignore as part of #5002, but could you still fix up the .gitignore? You'll just need to resolve merging conflicts.

@mhegazy mhegazy merged commit c43754f into microsoft:master Sep 28, 2015
@mhegazy

mhegazy commented Sep 28, 2015

Copy link
Copy Markdown
Contributor

never mind, merged manually. thanks.

@Eyas Eyas deleted the vscode-ignores branch October 2, 2015 00:33
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Eyas @msftclas @DanielRosenwasser @mhegazy
Morty Proxy This is a proxified and sanitized view of the page, visit original site.