Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

prerocess export import declarations correctly#4730

Merged
mhegazy merged 1 commit into
release-1.6microsoft/TypeScript:release-1.6from
fix4727microsoft/TypeScript:fix4727Copy head branch name to clipboard
Sep 10, 2015
Merged

prerocess export import declarations correctly#4730
mhegazy merged 1 commit into
release-1.6microsoft/TypeScript:release-1.6from
fix4727microsoft/TypeScript:fix4727Copy head branch name to clipboard

Conversation

@mhegazy

@mhegazy mhegazy commented Sep 10, 2015

Copy link
Copy Markdown
Contributor

fixes #4727

@DanielRosenwasser DanielRosenwasser changed the title prerocess export import declarations correctelly prerocess export import declarations correctly Sep 10, 2015
Comment thread src/services/services.ts

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be great if you had a helper function like

function scanYieldsSequence(scanner: Scanner, seq: (SyntaxKind | ((kind: SyntaxKind) => boolean))[]) {
    for (let item of seq) {
        let passes = item instanceof Function ?
            item(scanner.scan()) :
            item === scanner.scan()
        if (!passes) {
            return false;
        }
    }

    return true;
}

but it might be overkill

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, and yes :)

@DanielRosenwasser

Copy link
Copy Markdown
Member

👍

mhegazy added a commit that referenced this pull request Sep 10, 2015
prerocess `export import` declarations correctly
@mhegazy mhegazy merged commit 828c37e into release-1.6 Sep 10, 2015
@mhegazy mhegazy deleted the fix4727 branch September 10, 2015 21:19
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.