Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Housekeeping formatting rules #4711

Merged
mhegazy merged 4 commits into
microsoft:mastermicrosoft/TypeScript:masterfrom
saschanaz:mergeRulessaschanaz/TypeScript:mergeRulesCopy head branch name to clipboard
Sep 10, 2015
Merged

Housekeeping formatting rules #4711
mhegazy merged 4 commits into
microsoft:mastermicrosoft/TypeScript:masterfrom
saschanaz:mergeRulessaschanaz/TypeScript:mergeRulesCopy head branch name to clipboard

Conversation

@saschanaz

@saschanaz saschanaz commented Sep 9, 2015

Copy link
Copy Markdown
Contributor

(Separated from #4609)

  • Merge SpaceAfterAwaitKeyword and SpaceAfterTypeKeyword into SpaceAfterCertainKeywords and SpaceAfterCertainTypeScriptKeywords respectively.
  • Remove needless NoSpace rules
  • Remove type operation rules and instead add their types to IsBinaryOpContext

saschanaz added a commit to saschanaz/TypeScript that referenced this pull request Sep 9, 2015
@saschanaz
Move housekeeping part to new PR microsoft#4711
9ca46b8
@DanielRosenwasser

DanielRosenwasser commented Sep 9, 2015

Copy link
Copy Markdown
Member

👍

mhegazy added a commit that referenced this pull request Sep 10, 2015
@mhegazy
Merge pull request #4711 from SaschaNaz/mergeRules
4be0ddb 
Housekeeping formatting rules
@mhegazy mhegazy merged commit 4be0ddb into microsoft:master Sep 10, 2015
@mhegazy

mhegazy commented Sep 10, 2015

Copy link
Copy Markdown
Contributor

We need a formatting test for intersection and union though.

@saschanaz

saschanaz commented Sep 10, 2015

Copy link
Copy Markdown
Contributor Author

@mhegazy We have https://github.com/Microsoft/TypeScript/blob/master/tests/cases/fourslash/formatTypeOperation.ts currently.

@mhegazy

mhegazy commented Sep 10, 2015

Copy link
Copy Markdown
Contributor

Ok then. never mind.

@saschanaz saschanaz deleted the mergeRules branch September 11, 2015 04:49
saschanaz added a commit to saschanaz/TypeScript that referenced this pull request Sep 11, 2015
@saschanaz
Resolving a conflict with microsoft#4711
31ca74b
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@saschanaz @DanielRosenwasser @mhegazy @msftclas
Morty Proxy This is a proxified and sanitized view of the page, visit original site.