do not emit '=' in jsx attribute if initializer is missing#4703
Merged
vladima merged 1 commit intoSep 10, 2015
mastermicrosoft/TypeScript:masterfrom
jsxEmitAttribiteWithInitializermicrosoft/TypeScript:jsxEmitAttribiteWithInitializerCopy head branch name to clipboard
Merged
do not emit '=' in jsx attribute if initializer is missing#4703vladima merged 1 commit intomastermicrosoft/TypeScript:masterfrom jsxEmitAttribiteWithInitializermicrosoft/TypeScript:jsxEmitAttribiteWithInitializerCopy head branch name to clipboard
vladima merged 1 commit into
mastermicrosoft/TypeScript:masterfrom
jsxEmitAttribiteWithInitializermicrosoft/TypeScript:jsxEmitAttribiteWithInitializerCopy head branch name to clipboard
Conversation
Member
|
👍 @mhegazy does this need to go into 1.6? |
Contributor
|
👍 |
Contributor
|
fix looks safe. let's port it to 1.6 |
vladima
added a commit
that referenced
this pull request
Sep 10, 2015
do not emit '=' in jsx attribute if initializer is missing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #4645