Add comment and handle intersection types in gotoType#4698
Closed
mhegazy wants to merge 3 commits into
Closed
Add comment and handle intersection types in gotoType#4698mhegazy wants to merge 3 commits into
mhegazy wants to merge 3 commits into
Conversation
Member
There was a problem hiding this comment.
synthetic -> a synthetic
union of -> union/intersection of
Contributor
There was a problem hiding this comment.
I would rewrite it as
if (syntheticPropertyKind) {
return syntheticPropertyKind;
}
let typeOfSyntheticProperty = typeChecker.getTypeOfSymbolAtLocation(symbol, location);
return typeOfSyntheticProperty.getCallSignatures().length
? ScriptElementKind.memberFunctionElement
: ScriptElementKind.memberVariableElement;
Contributor
There was a problem hiding this comment.
btw, are all changes in this block just renames?
Member
|
Can you port this into |
Member
|
Ping |
1 similar comment
Member
|
Ping |
Member
|
He's in Egypt 😉 Does someone else need to handle this? I don't see a bug on it |
Contributor
Author
|
this is fairly stale by now. closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up on #4632