Fix emitted code for variable statement with no bound variables#4657
Merged
DanielRosenwasser merged 10 commits intoSep 9, 2015
release-1.6microsoft/TypeScript:release-1.6from
emptyVariableDeclarationBindingPatternmicrosoft/TypeScript:emptyVariableDeclarationBindingPatternCopy head branch name to clipboard
Merged
Fix emitted code for variable statement with no bound variables#4657DanielRosenwasser merged 10 commits intorelease-1.6microsoft/TypeScript:release-1.6from emptyVariableDeclarationBindingPatternmicrosoft/TypeScript:emptyVariableDeclarationBindingPatternCopy head branch name to clipboard
DanielRosenwasser merged 10 commits into
release-1.6microsoft/TypeScript:release-1.6from
emptyVariableDeclarationBindingPatternmicrosoft/TypeScript:emptyVariableDeclarationBindingPatternCopy head branch name to clipboard
Conversation
Contributor
There was a problem hiding this comment.
can you also add a test for assignments,
var a: any;
({} = a);
([] = a);
({}) => { };
([]) => { };
Member
Author
There was a problem hiding this comment.
Contributor
|
Does this work for parameters? function f({} = {}) { }
function g([] = []) { } |
Member
Author
|
We have |
Member
Author
|
Actually @JsonFreeman, since the issue was when an identifier appeared in the initializer, that's what we should be testing. I'll amend my tests. |
Member
Author
|
Done. I've added cases in
|
DanielRosenwasser
added a commit
that referenced
this pull request
Sep 9, 2015
…ngPattern Fix emitted code for variable statement with no bound variables
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3893.