Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Remove vestigial baselines#45916

Merged
andrewbranch merged 3 commits into
microsoft:mainmicrosoft/TypeScript:mainfrom
jablko:patch-39jablko/TypeScript:patch-39Copy head branch name to clipboard
Sep 16, 2021
Merged

Remove vestigial baselines#45916
andrewbranch merged 3 commits into
microsoft:mainmicrosoft/TypeScript:mainfrom
jablko:patch-39jablko/TypeScript:patch-39Copy head branch name to clipboard

Conversation

@jablko

@jablko jablko commented Sep 16, 2021

Copy link
Copy Markdown
Contributor

These baselines are leftovers and can be removed?

  • gulp runtests doesn't recreate them.
  • The tests all pass without them.

What I did was:

  • Add git rm -r --quiet tests/baselines/reference :^tests/baselines/reference/docker :^tests/baselines/reference/user -> .github/workflows/accept-baselines-fix-lints.yaml
  • Run that workflow to remove any unused baselines.

@typescript-bot typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Sep 16, 2021
@typescript-bot

Copy link
Copy Markdown
Contributor

This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise.

@andrewbranch andrewbranch left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I knew there must be a good number of these. Your git skills are better than mine 😁

@jablko

jablko commented Sep 16, 2021

Copy link
Copy Markdown
Contributor Author

Thanks!

@andrewbranch andrewbranch merged commit 6aaefe4 into microsoft:main Sep 16, 2021
@microsoft microsoft locked as resolved and limited conversation to collaborators Oct 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

For Uncommitted Bug PR for untriaged, rejected, closed or missing bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.