Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Fix main by using '.default' on the new ms release#45910

Merged
andrewbranch merged 4 commits into
microsoft:mainmicrosoft/TypeScript:mainfrom
orta:main_fixorta/TypeScript:main_fixCopy head branch name to clipboard
Sep 16, 2021
Merged

Fix main by using '.default' on the new ms release#45910
andrewbranch merged 4 commits into
microsoft:mainmicrosoft/TypeScript:mainfrom
orta:main_fixorta/TypeScript:main_fixCopy head branch name to clipboard

Conversation

@orta

@orta orta commented Sep 16, 2021

Copy link
Copy Markdown
Contributor

Fixes main - because we update the lockfile, we now use ms v3 which is re-written in TypeScript but has a different export style.

@typescript-bot typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Sep 16, 2021
@orta

orta commented Sep 16, 2021

Copy link
Copy Markdown
Contributor Author

should unblock #45905

@orta

orta commented Sep 16, 2021

Copy link
Copy Markdown
Contributor Author

Hrm, looks like it ships ?. in JS which isn't as backwards compatible as our CI - maybe I should just lock it to v2 instead

@andrewbranch andrewbranch merged commit b250f0c into microsoft:main Sep 16, 2021
@andrewbranch

Copy link
Copy Markdown
Member

Thanks!

@microsoft microsoft locked as resolved and limited conversation to collaborators Oct 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.