feat(42639): "in" operator not narrowing the type if used with a const#44893
Merged
Merged
feat(42639): "in" operator not narrowing the type if used with a const#44893
Conversation
gabritto
reviewed
Jul 21, 2021
gabritto
left a comment
Member
There was a problem hiding this comment.
I had a minor question, but otherwise looks good to me, thanks for contributing.
…r on the left side
gabritto
approved these changes
Jul 21, 2021
gabritto
left a comment
Member
There was a problem hiding this comment.
thanks, everything seems good now
Member
|
@typescript-bot perf test this (not sure if it works on merged PRs?) |
Contributor
|
Heya @andrewbranch, I've started to run the perf test suite on this PR at 278f172. You can monitor the build here. |
Member
|
(It doesn’t) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #42639