Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

fix(41299): Support Intl.NumberFormat.formatToParts in ES2018#44566

Closed
rastenis wants to merge 6 commits into
microsoft:mainmicrosoft/TypeScript:mainfrom
rastenis:fix41299rastenis/TypeScript:fix41299Copy head branch name to clipboard
Closed

fix(41299): Support Intl.NumberFormat.formatToParts in ES2018#44566
rastenis wants to merge 6 commits into
microsoft:mainmicrosoft/TypeScript:mainfrom
rastenis:fix41299rastenis/TypeScript:fix41299Copy head branch name to clipboard

Conversation

@rastenis

Copy link
Copy Markdown
Contributor

Fixes #41299

@typescript-bot typescript-bot added the For Backlog Bug PRs that fix a backlog bug label Jun 12, 2021
@typescript-bot

Copy link
Copy Markdown
Contributor

It looks like you've sent a pull request to update our 'lib' files. These files aren't meant to be edited by hand, as they consist of last-known good states of the compiler and are generated from 'src'. Unless this is necessary, consider closing the pull request and sending a separate PR to update 'src'.

@typescript-bot typescript-bot added the lib update PR modifies files in the `lib` folder label Jul 9, 2021
@rastenis rastenis marked this pull request as ready for review July 9, 2021 10:33
@rastenis

rastenis commented Jul 9, 2021

Copy link
Copy Markdown
Contributor Author

I have moved formatToParts to ES2018, and subsequently removed esnext.intl.d.ts, as it was empty after the migration. Everything seems OK, but I'd like a second set of eyes to check if I have completed all of the redirections and removals properly.

@sandersn sandersn requested review from orta and sandersn July 15, 2021 23:04
@orta

orta commented Sep 8, 2021

Copy link
Copy Markdown
Contributor

Thanks @Scharkee - I've taken this and merged it into 4.5 with #45647

@orta orta closed this Sep 8, 2021
@microsoft microsoft locked as resolved and limited conversation to collaborators Oct 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

For Backlog Bug PRs that fix a backlog bug lib update PR modifies files in the `lib` folder

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Support Intl.NumberFormat.formatToParts in ES2018

4 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.