Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

fix: code fix wrapJsxInFragment not working in new JSX emit#44111

Closed
Jack-Works wants to merge 1 commit into
microsoft:mastermicrosoft/TypeScript:masterfrom
Jack-Works:fix-37917Jack-Works/TypeScript:fix-37917Copy head branch name to clipboard
Closed

fix: code fix wrapJsxInFragment not working in new JSX emit#44111
Jack-Works wants to merge 1 commit into
microsoft:mastermicrosoft/TypeScript:masterfrom
Jack-Works:fix-37917Jack-Works/TypeScript:fix-37917Copy head branch name to clipboard

Conversation

@Jack-Works

Copy link
Copy Markdown
Contributor

I implemented "Wrap in JSX Fragment" in #37917. It explicitly detects if the JSXEmit is React or ReactNative. When TypeScript supports the new JSX emit comes out, this file didn't be changed to reflect the new change. The result is this code fix is not working when using the new JSX emit.

@typescript-bot typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label May 16, 2021
@typescript-bot

Copy link
Copy Markdown
Contributor

This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise.

@Jack-Works

Copy link
Copy Markdown
Contributor Author

Duplicate of #43635

@Jack-Works Jack-Works closed this May 21, 2021
@Jack-Works Jack-Works deleted the fix-37917 branch May 21, 2021 00:49
@microsoft microsoft locked as resolved and limited conversation to collaborators Oct 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

For Uncommitted Bug PR for untriaged, rejected, closed or missing bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.