Contextual typing checks property assignments for type annotation#43598
Merged
sandersn merged 1 commit intoApr 26, 2021
mastermicrosoft/TypeScript:masterfrom
check-property-assignments-for-type-annotationmicrosoft/TypeScript:check-property-assignments-for-type-annotationCopy head branch name to clipboard
Merged
Contextual typing checks property assignments for type annotation#43598sandersn merged 1 commit intomastermicrosoft/TypeScript:masterfrom check-property-assignments-for-type-annotationmicrosoft/TypeScript:check-property-assignments-for-type-annotationCopy head branch name to clipboard
sandersn merged 1 commit into
mastermicrosoft/TypeScript:masterfrom
check-property-assignments-for-type-annotationmicrosoft/TypeScript:check-property-assignments-for-type-annotationCopy head branch name to clipboard
Conversation
Property assignments can have a type annotation in JS. This PR adds a check for it in contextual typing. Fixes #43379
Member
Author
|
@andrewbranch you just looked at contextual typing in JS object literals...mind taking a look at this change too? |
andrewbranch
approved these changes
Apr 26, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Property assignments can have a type annotation in JS. This PR adds a check for it in contextual typing.
Fixes #43379