getSemanticDocumentHighlights: don't fail...#43372
Merged
Merged
getSemanticDocumentHighlights: don't fail...#43372
getSemanticDocumentHighlights: don't fail...#43372Conversation
...when missing `program.redirectTargetsMap` info. This assertion fails in the added test case -- looks like there is no entry in `program.redirectTargetsMap` when it comes from a file that is no in the project. So in this case don't follow the (missing) info, and instead drop the highlight. Fixes microsoft#33722.
RyanCavanaugh
approved these changes
Mar 25, 2021
sheetalkamat
approved these changes
Mar 25, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
...when missing
program.redirectTargetsMapinfo. This assertion failsin the added test case -- looks like there is no entry in
program.redirectTargetsMapwhen it comes from a file that is no in theproject. So in this case don't follow the (missing) info, and instead
drop the highlight.
Fixes #33722.