fix(43160): improve error location for functions without explicit return#43367
Merged
Merged
fix(43160): improve error location for functions without explicit return#43367
Conversation
sandersn
requested changes
Apr 5, 2021
sandersn
left a comment
Member
There was a problem hiding this comment.
Very nice improvement. One request to make the function even easier to read.
| // NOTE: having returnType !== undefined is a precondition for entering this branch so func.type will always be present | ||
| error(getEffectiveReturnTypeNode(func), Diagnostics.A_function_whose_declared_type_is_neither_void_nor_any_must_return_a_value); | ||
| // NOTE: returnType may not exist when func.type is denoted by jsdoc | ||
| error(getEffectiveReturnTypeNode(func) || func, Diagnostics.A_function_whose_declared_type_is_neither_void_nor_any_must_return_a_value); |
Member
There was a problem hiding this comment.
all 4 four branches of this if at the end of the function now have getEffectiveReturnTypeNode(func) || func, so I'd lift it out before the first if as const errorNode = getEffectiveReturnTypeNode(func) || func
If you can, you should find or write a new test for the type.flags & TypeFlags.Never case above as well.
sandersn
approved these changes
Apr 6, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #43160