🤖 Pick PR #42766 (Avoid getting undefined `callSignat...) into release-4.2#42950
Merged
RyanCavanaugh merged 1 commit intoFeb 25, 2021
microsoft:release-4.2microsoft/TypeScript:release-4.2from
typescript-bot:pick/42766/release-4.2typescript-bot/TypeScript:pick/42766/release-4.2Copy head branch name to clipboard
Merged
🤖 Pick PR #42766 (Avoid getting undefined `callSignat...) into release-4.2#42950RyanCavanaugh merged 1 commit intomicrosoft:release-4.2microsoft/TypeScript:release-4.2from typescript-bot:pick/42766/release-4.2typescript-bot/TypeScript:pick/42766/release-4.2Copy head branch name to clipboard
RyanCavanaugh merged 1 commit into
microsoft:release-4.2microsoft/TypeScript:release-4.2from
typescript-bot:pick/42766/release-4.2typescript-bot/TypeScript:pick/42766/release-4.2Copy head branch name to clipboard
Conversation
Component commits: ed26816 Avoid getting undefined `callSignatures`/`constructSignatures` in `getPropertyOfType` e350c35 (microsoft#40228) introduced a subtle bug: it switched the flags to an alias, dropping `SymbolFlags.Property` --- and that makes `symbolIsValue()` get to the `resolveAlias(symbol)` call, which leads to `getPropertyOfType()` with`resolved.callSignatures`+`constructSignatures` being `undefined`. So initialize them in `setStructuredTypeMembers` before calling `getNamedMembers()`. Fixes microsoft#42350
Contributor
Author
|
This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise. |
This was referenced Mar 6, 2021
Merged
This was referenced Mar 17, 2021
chore(deps-dev): bump typescript from 3.9.9 to 4.2.3 in /deployments
hollanddd/second-rate.website#2
Closed
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This cherry-pick was triggered by a request on #42766
Please review the diff and merge if no changes are unexpected.
You can view the cherry-pick log here.
cc @andrewbranch