Improve @template lookup and resilience#42851
Merged
sandersn merged 3 commits intoFeb 18, 2021
mastermicrosoft/TypeScript:masterfrom
improve-template-tag-lookupmicrosoft/TypeScript:improve-template-tag-lookupCopy head branch name to clipboard
Merged
Improve @template lookup and resilience#42851sandersn merged 3 commits intomastermicrosoft/TypeScript:masterfrom improve-template-tag-lookupmicrosoft/TypeScript:improve-template-tag-lookupCopy head branch name to clipboard
sandersn merged 3 commits into
mastermicrosoft/TypeScript:masterfrom
improve-template-tag-lookupmicrosoft/TypeScript:improve-template-tag-lookupCopy head branch name to clipboard
Conversation
1. @template parsing may produce a template tag with a type parameter whose name is the missing identifier. These tags should be skipped in the checker because they receive an error in the parser. 2. The fix in #37819 was incorrect; there's no such thing as a type parameter declared on a variable declaration. Instead, there needs to be a type parameter declared on a jsdoc comment, because that's the scope for tags like `@return` and `@typedef`. There are 3 tests because either fix (1) and (2) fix the first test's failure, but both are required to fix the last two tests' failures.
andrewbranch
approved these changes
Feb 18, 2021
|
|
||
| export function getJSDocTypeParameterDeclarations(node: DeclarationWithTypeParameters): readonly TypeParameterDeclaration[] { | ||
| return flatMap(getJSDocTags(node), tag => isNonTypeAliasTemplate(tag) ? tag.typeParameters : undefined); | ||
| return flatMap(getJSDocTags(node), tag => isNonTypeAliasTemplate(tag) ? tag.typeParameters.filter(p => !containsParseError(p)) : undefined); |
Member
There was a problem hiding this comment.
I heard u like Haskell
Suggested change
| return flatMap(getJSDocTags(node), tag => isNonTypeAliasTemplate(tag) ? tag.typeParameters.filter(p => !containsParseError(p)) : undefined); | |
| return flatMap(getJSDocTags(node), tag => isNonTypeAliasTemplate(tag) ? tag.typeParameters.filter(not(containsParseError)) : undefined); |
Member
Author
There was a problem hiding this comment.
Um....oops. This isn't needed since I found that the Pursuit fellows made a better fix in December.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
parameter declared on a jsdoc comment, because that's the scope for tags like
@returnand@typedef.There are 3 tests because either fix (1) and (2) fix the first test's failure, but both are required to fix the last two tests' failures.
Fixes #42812
Edit: The fix in (1) isn't as good as the one in #42017, so I'm going to take that and leave the test cases in place.