Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

fix(lib/es2015): Fix types of Reflect methods#41987

Merged
orta merged 1 commit into
microsoft:mastermicrosoft/TypeScript:masterfrom
ExE-Boss:lib/es2015/fix-reflect-method-typesExE-Boss/TypeScript:lib/es2015/fix-reflect-method-typesCopy head branch name to clipboard
Jan 4, 2021
Merged

fix(lib/es2015): Fix types of Reflect methods#41987
orta merged 1 commit into
microsoft:mastermicrosoft/TypeScript:masterfrom
ExE-Boss:lib/es2015/fix-reflect-method-typesExE-Boss/TypeScript:lib/es2015/fix-reflect-method-typesCopy head branch name to clipboard

Conversation

@ExE-Boss

@ExE-Boss ExE-Boss commented Dec 16, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

Unlike #35608, this only fixes the types so that the return types of Reflect.ownKeys(…) and Reflect.getPrototypeOf(…) are correct.

Blocks:

Fixes #34626

/cc @Jessidhia @orta @rbuckton @sandersn

@typescript-bot typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Dec 16, 2020
@typescript-bot

typescript-bot commented Dec 16, 2020

Copy link
Copy Markdown
Contributor

This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise.

This was referenced Dec 16, 2020
Merged
Merged
@ExE-Boss ExE-Boss force-pushed the lib/es2015/fix-reflect-method-types branch from edb0009 to 75dd434 Compare December 16, 2020 03:02
@ExE-Boss ExE-Boss mentioned this pull request Dec 16, 2020
Closed
@sandersn sandersn requested review from orta and rbuckton December 30, 2020 19:31
@sandersn sandersn self-requested a review December 30, 2020 19:31
@orta

orta commented Jan 4, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

I compared each function to the MDN docs for the reflect API, and that all seems to look right to me - thanks @ExE-Boss

@orta orta merged commit 562237d into microsoft:master Jan 4, 2021
@ExE-Boss ExE-Boss deleted the lib/es2015/fix-reflect-method-types branch January 4, 2021 10:30
@monfera monfera mentioned this pull request Jan 4, 2021
Closed
@monfera

monfera commented Jan 4, 2021

Copy link
Copy Markdown

@ExE-Boss great change, thanks! Looks like lib/lib.es2015.reflect.d.ts needs to be updated for userland code who install via eg. yarn and "typescript": "microsoft/TypeScript#master", in the devDependencies; also tried yarn add -D typescript@next, still getting the old definitions from lib/lib.es2015.reflect.d.ts. Maybe there's some extra build step?

@Luxcium

Luxcium commented Jan 6, 2021 •
edited
Loading

Copy link
Copy Markdown

I would like to know what is the return type of Reflect.ownKeys(target) is it of Type '(string | number | symbol)[]' or of Type '(string | symbol)[]' ??? (Sorry to be so confused I am the kind of person who likes to annotate all my functions output types and now I am using /* : (string | number | symbol)[] */ yes with the /* and the */ haha !!!

Screenshot_20210105_230211

@ExE-Boss

ExE-Boss commented Jan 6, 2021

Copy link
Copy Markdown
Contributor Author

@Luxcium The correct return type of Reflect.ownKeys(target) is (string | symbol)[]:

@sandersn sandersn mentioned this pull request Jan 15, 2021
Merged
Zzzen pushed a commit to Zzzen/TypeScript that referenced this pull request Jan 16, 2021
@ExE-Boss @Zzzen
fix(lib/es2015): Fix types of Reflect methods (microsoft#41987)
bdfc5e5
@ExE-Boss ExE-Boss mentioned this pull request Mar 2, 2021
Open
5 tasks
@microsoft microsoft locked as resolved and limited conversation to collaborators Oct 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@orta orta Awaiting requested review from orta

@rbuckton rbuckton Awaiting requested review from rbuckton

@sandersn sandersn Awaiting requested review from sandersn

Assignees

@orta orta

Labels

For Uncommitted Bug PR for untriaged, rejected, closed or missing bug

Projects

PR Backlog
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Reflect.ownKeys has overly wide type definition

6 participants

@ExE-Boss @typescript-bot @orta @monfera @Luxcium @sandersn
Morty Proxy This is a proxified and sanitized view of the page, visit original site.