Fix visibility lookup for cjs require aliases#41257
Merged
weswigham merged 2 commits intoOct 27, 2020
microsoft:mastermicrosoft/TypeScript:masterfrom
weswigham:jsdoc-declaration-emit-namesweswigham/TypeScript:jsdoc-declaration-emit-namesCopy head branch name to clipboard
Merged
Fix visibility lookup for cjs require aliases#41257weswigham merged 2 commits intomicrosoft:mastermicrosoft/TypeScript:masterfrom weswigham:jsdoc-declaration-emit-namesweswigham/TypeScript:jsdoc-declaration-emit-namesCopy head branch name to clipboard
weswigham merged 2 commits into
microsoft:mastermicrosoft/TypeScript:masterfrom
weswigham:jsdoc-declaration-emit-namesweswigham/TypeScript:jsdoc-declaration-emit-namesCopy head branch name to clipboard
Conversation
sandersn
approved these changes
Oct 26, 2020
| else if (isBindingElement(declaration) && isInJSFile(declaration) && declaration.parent?.parent // exported import-like top-level JS require statement | ||
| && isVariableDeclaration(declaration.parent.parent) | ||
| && declaration.parent.parent.parent?.parent && isVariableStatement(declaration.parent.parent.parent.parent) | ||
| && !hasSyntacticModifier(declaration.parent.parent.parent.parent, ModifierFlags.Export) |
Member
There was a problem hiding this comment.
should we care about checking for const or require here? Probably doesn't matter because I don't think there are any other declarations that look like const { x } = require('y').
Member
Author
There was a problem hiding this comment.
Maybe. Might just be worth checking for symbol.flags & SymbolFlags.Alias.
…ich are declarations of aliases
andrewbranch
approved these changes
Oct 27, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the easier half of #41250 (painting the visibility of
const {Item} = require("...")statements), which is otherwise still broken with this change. You can see how this change positively affects an existing baseline.