Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

fix export * as default syntax#39803

Merged
DanielRosenwasser merged 2 commits into
microsoft:mastermicrosoft/TypeScript:masterfrom
Kingwl:export_star_as_defaultKingwl/TypeScript:export_star_as_defaultCopy head branch name to clipboard
Aug 10, 2020
Merged

fix export * as default syntax#39803
DanielRosenwasser merged 2 commits into
microsoft:mastermicrosoft/TypeScript:masterfrom
Kingwl:export_star_as_defaultKingwl/TypeScript:export_star_as_defaultCopy head branch name to clipboard

Conversation

@Kingwl

@Kingwl Kingwl commented Jul 29, 2020

Copy link
Copy Markdown
Contributor

Fixes #39769
Fixes #39803

@typescript-bot typescript-bot added the For Milestone Bug PRs that fix a bug with a specific milestone label Jul 29, 2020
@DanielRosenwasser

DanielRosenwasser commented Jul 29, 2020

Copy link
Copy Markdown
Member

[[Do not merge before Friday]]

@sandersn sandersn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question.

The implementation looks reasonable to me, but @rbuckton should definitely sign off on the emitted code before this goes in.

Comment thread src/compiler/parser.ts
Comment thread src/compiler/transformers/module/module.ts

@rbuckton rbuckton left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The emit seems fine to me.

@Kingwl

Kingwl commented Jul 30, 2020

Copy link
Copy Markdown
Contributor Author

[[Do not merge before Friday]]

Maybe you need a label Don't merge now :XD

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

For Milestone Bug PRs that fix a bug with a specific milestone

Projects

None yet

Development

Successfully merging this pull request may close these issues.

export * as default from "module" syntax should work as per ECMA-262

5 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.