microsoft · orta · Jul 6, 2020 · Jun 23, 2020 · Jun 23, 2020 · Jun 23, 2020
diff --git a/.github/tsc.json b/.github/tsc.json
@@ -0,0 +1,18 @@
+{
+  "problemMatcher": [
+      {
+          "owner": "tsc",
+          "pattern": [
+              {
+                  "regexp": "^(?:\\s+\\d+\\>)?([^\\s].*)\\((\\d+),(\\d+)\\)\\s*:\\s+(error|warning|info)\\s+(\\w{1,2}\\d+)\\s*:\\s*(.*)$",
+                  "file": 1,
+                  "line": 2,
+                  "column": 3,
+                  "severity": 4,
+                  "code": 5,
+                  "message": 6
+              }
+          ]
+      }
+  ]
+}
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -30,12 +30,19 @@ jobs:
      run: |
        npm uninstall typescript --no-save
        npm uninstall tslint --no-save
-    - name: npm install and test
-      run: |
-        npm install
-        npm update
-        npm test
-
+    - run:  npm install
+    - run:  npm update
+
+    # Re: https://github.com/actions/setup-node/pull/125
+    - name: Register Problem Matcher for TSC
+      run: echo "##[add-matcher].github/tsc.json"
+
+    - name: Tests
+      run:  npm test -- --no-lint
+
+    - name: Linter
+      run:  npm run lint:ci
+
    - name: Validate the browser can import TypeScript
      run: gulp test-browser-integration

diff --git a/Gulpfile.js b/Gulpfile.js
@@ -354,7 +354,6 @@ const eslint = (folder) => async () => {
        "node_modules/eslint/bin/eslint",
        "--cache",
        "--cache-location", `${folder}/.eslintcache`,
-        "--format", "autolinkable-stylish",
        "--rulesdir", "scripts/eslint/built/rules",
        "--ext", ".ts",
    ];
@@ -363,11 +362,19 @@ const eslint = (folder) => async () => {
        args.push("--fix");
    }

+    // Use stylish format on CI, so that it can be picked up by GH Action's rule matchers
+    if (cmdLineOptions.ci) {
+        args.push("--format", "stylish");
+    }
+    else {
+        args.push("--format", "autolinkable-stylish");
+    }
+
    args.push(folder);

    log(`Linting: ${args.join(" ")}`);
    return exec(process.execPath, args);
-}
+};

 const lintScripts = eslint("scripts");
 lintScripts.displayName = "lint-scripts";
-Original file line number
+Diff line change
@@ -354,7 +354,6 @@ const eslint = (folder) => async () => {
             "node_modules/eslint/bin/eslint",
             "--cache",
             "--cache-location", `${folder}/.eslintcache`,
-            "--format", "autolinkable-stylish",
             "--rulesdir", "scripts/eslint/built/rules",
             "--ext", ".ts",
         ];
@@ -363,11 +362,19 @@ const eslint = (folder) => async () => {
             args.push("--fix");
         }
+        // Use stylish format on CI, so that it can be picked up by GH Action's rule matchers
+        if (cmdLineOptions.ci) {
+            args.push("--format", "stylish");
+        }
+        else {
+            args.push("--format", "autolinkable-stylish");
+        }
         Comment thread


        

        
      

        
          


  
    
        
        
  
    
      
          
      

      
            orta
  

      

      

      


        Jun 23, 2020



      
    

  

  
    
      
          
    
  


        
            
  
      
              Copy link

  
              
  
      
                Copy Markdown

  
        
      
    

    
        

  
    Contributor


        

  Author


    
  


        
      
  
  
  
    

    There was a problem hiding this comment.


  

 
  
    

    Choose a reason for hiding this comment

    
      The reason will be displayed to describe this comment to others. Learn more.
    

    
      
      


  


  
    
      Stylish:
/Users/ortatherox/dev/typescript/typescript-compiler/src/compiler/builderState.ts
  93:90  error  Missing semicolon  @typescript-eslint/semi
  94:83  error  Missing semicolon  @typescript-eslint/semi

Autolinkable Stylish
Error: /Users/ortatherox/dev/typescript/typescript-compiler/src/compiler/builderState.ts:93:90 @typescript-eslint/semi Missing semicolon.
Error: /Users/ortatherox/dev/typescript/typescript-compiler/src/compiler/builderState.ts:94:83 @typescript-eslint/semi Missing semicolon.

Stylish support is shipped with setup-node here: https://github.com/actions/setup-node/blob/master/.github/eslint-stylish.json
    
  
  



    

        
      
  
  
    
  
  
  
    
    Sorry, something went wrong.
  

  
    
  
    
      

              Uh oh!

              
There was an error while loading. Please reload this page.


  
  


          
              
  
    
    
      
        
            
    All reactions
  


          
          
        
      
    


      



    
        
  
    
      
          
      

      
            orta
  

      

      

      


        Jun 23, 2020



      
    

  

  
    
      
          
    
  


        
            
  
      
              Copy link

  
              
  
      
                Copy Markdown

  
        
      
    

    
        

  
    Contributor


        

  Author


    
  


        
      
  
  
  
    

    There was a problem hiding this comment.


  

 
  
    

    Choose a reason for hiding this comment

    
      The reason will be displayed to describe this comment to others. Learn more.
    

    
      
      


  


  
    
      Looks like this in the files tab of the PR:


    
  
  



    

        
      
  
  
    
  
  
  
    
    Sorry, something went wrong.
  

  
    
  
    
      

              Uh oh!

              
There was an error while loading. Please reload this page.


  
  


          
              
  
    
    
      
        
            
    All reactions
         args.push(folder);
         log(`Linting: ${args.join(" ")}`);
         return exec(process.execPath, args);
-    }
+    };
     const lintScripts = eslint("scripts");
     lintScripts.displayName = "lint-scripts";
-          Expand Down