Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

fix(25155): insertSpaceBeforeTypeAnnotation doesn't work with optional parameters / properties#38798

Merged
andrewbranch merged 1 commit into
microsoft:mastermicrosoft/TypeScript:masterfrom
a-tarasyuk:bug/25155a-tarasyuk/TypeScript:bug/25155Copy head branch name to clipboard
Jul 8, 2020
Merged

fix(25155): insertSpaceBeforeTypeAnnotation doesn't work with optional parameters / properties#38798
andrewbranch merged 1 commit into
microsoft:mastermicrosoft/TypeScript:masterfrom
a-tarasyuk:bug/25155a-tarasyuk/TypeScript:bug/25155Copy head branch name to clipboard

Conversation

@a-tarasyuk

Copy link
Copy Markdown
Contributor

Fixes #25155

Comment thread tests/cases/fourslash/formatTypeAnnotation1.ts
Comment thread tests/cases/fourslash/formatTypeAnnotation2.ts Outdated
Comment thread tests/cases/fourslash/formatTypeAnnotation1.ts
@andrewbranch andrewbranch merged commit 48c19ee into microsoft:master Jul 8, 2020
cangSDARM added a commit to cangSDARM/TypeScript that referenced this pull request Jul 9, 2020
* upstream/master: (75 commits)
  Insert auto-imports in sorted order (microsoft#39394)
  LEGO: check in for master to temporary branch.
  Better checking of @param/@Property tags (microsoft#39487)
  fix(25155): add space before optional parameters/properties (microsoft#38798)
  Add regression test for microsoft#38834 (microsoft#39479)
  Fixes searches for symbols exported using export * as (microsoft#39507)
  fix(39421): omit prefix text for rest binding element (microsoft#39433)
  fix(39440): show QF for abstract classes with methods which include 'this' parameter (microsoft#39465)
  Remove unnecessary assert (microsoft#39483)
  LEGO: check in for master to temporary branch.
  Update user baselines (microsoft#39220)
  Type `this` in more constructor functions (microsoft#39447)
  LEGO: check in for master to temporary branch.
  LEGO: check in for master to temporary branch.
  Properly handle rest parameters in function declarations with @type annotations (microsoft#39473)
  Ensure type/namespaceish statics are included in the list of namespace merge members (microsoft#38920)
  Fix getTypeAtLocation for dotted implements clauses (microsoft#39363)
  Add workflow_dispatch to our nightly publish script. (microsoft#39485)
  Fix crash in decorator metadata calculation when serializing template literal type nodes (microsoft#39481)
  Fix test semantic merge conflict between microsoft#39348 and microsoft#39130 (microsoft#39478)
  ...

# Conflicts:
#	src/compiler/scanner.ts
@microsoft microsoft locked as resolved and limited conversation to collaborators Oct 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

insertSpaceBeforeTypeAnnotation doesn't work with optional parameters / properties

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.