Highlight Abstract occurrences#3846
Highlight Abstract occurrences#3846DanielRosenwasser merged 4 commits intomicrosoft:mastermicrosoft/TypeScript:masterfrom DickvdBrink:abstract-occurrencesDickvdBrink/TypeScript:abstract-occurrencesCopy head branch name to clipboard
Conversation
|
👍 |
There was a problem hiding this comment.
These are testing the same thing. I think you mean ClassExpression? But then you can't make a class expression abstract. Please add a test for that.
There was a problem hiding this comment.
Don't think these are the same or am I wrong here? On members of a class the container.kind is the ClassDeclaration, on the abstract keyword of the class the container is actually a source file so that is why I added the declaration.kind check.
Will do some test for ClassExpressions. Thanks for the feedback!
There was a problem hiding this comment.
Btw: This is what you meant with ClassExpression right?
function yolo() {
abstract class test {
foo: number;
}
}
I get an error that Modifiers cannot appear here
|
Can we
|
|
Done, I think I did it the way you wanted :) |
|
Well I made a mistake in my instructions - I said |
Highlight Abstract occurrences
|
Thanks! |
My attempt at highlighting
abstractkeyword (#3840)Can add more tests if required.
Feel free to close if you want this solved differently.