Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Fix jsdoc variadic type nodes not being remapped to equivalent TS in output#38276

Merged
weswigham merged 1 commit into
microsoft:mastermicrosoft/TypeScript:masterfrom
weswigham:cut-jsdoc-declaration-variadic-fixweswigham/TypeScript:cut-jsdoc-declaration-variadic-fixCopy head branch name to clipboard
May 2, 2020
Merged

Fix jsdoc variadic type nodes not being remapped to equivalent TS in output#38276
weswigham merged 1 commit into
microsoft:mastermicrosoft/TypeScript:masterfrom
weswigham:cut-jsdoc-declaration-variadic-fixweswigham/TypeScript:cut-jsdoc-declaration-variadic-fixCopy head branch name to clipboard

Conversation

@weswigham
Copy link
Copy Markdown
Member

Fixes #38242

Extracted from #38234~

@weswigham weswigham merged commit 5b0194b into microsoft:master May 2, 2020
@weswigham
Copy link
Copy Markdown
Member Author

@typescript-bot cherry-pick this to release-3.9

@typescript-bot
Copy link
Copy Markdown
Collaborator

typescript-bot commented May 2, 2020

Heya @weswigham, I've started to run the task to cherry-pick this into release-3.9 on this PR at b664c3d. You can monitor the build here.

@typescript-bot
Copy link
Copy Markdown
Collaborator

Hey @weswigham, I've opened #38300 for you.

typescript-bot pushed a commit to typescript-bot/TypeScript that referenced this pull request May 2, 2020
Component commits:
b664c3d Fix jsdoc variadic type nodes not being remapped to equivalent TS in output
weswigham added a commit that referenced this pull request May 4, 2020
Component commits:
b664c3d Fix jsdoc variadic type nodes not being remapped to equivalent TS in output

Co-authored-by: Wesley Wigham <t-weswig@microsoft.com>
@microsoft microsoft locked as resolved and limited conversation to collaborators Oct 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3.9 regression: varargs in declaration files for JavaScript files break declaration syntax

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.