Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

New mocha reporter#3820

Merged
danquirk merged 3 commits into
mastermicrosoft/TypeScript:masterfrom
newMochaReportersmicrosoft/TypeScript:newMochaReportersCopy head branch name to clipboard
Jul 14, 2015
Merged

New mocha reporter#3820
danquirk merged 3 commits into
mastermicrosoft/TypeScript:masterfrom
newMochaReportersmicrosoft/TypeScript:newMochaReportersCopy head branch name to clipboard

Conversation

@danquirk

Copy link
Copy Markdown
Member

Pretty simple change but the diff seems a little confused by some whitespace/reformatting changes. I made a new mocha reporter here https://github.com/danquirk/mocha-fivemat-progress-reporter that will report test output by test suite with a progress bar instead of one giant set of dots. This turns it on by default for jake runtests

Note that after merging this everyone will be required to run npm install again to get the new reporter.

The final output when tests complete is unchanged, total time and a final list of aggregated failures are still reported.

Ex:

newreporter

@danquirk

Copy link
Copy Markdown
Member Author

@DanielRosenwasser mentioned he might miss his red dots as some crazy means of figuring out which test failed. We could turn the progress bar red as soon as a failure occurs:

image

Alternatively/in addition we can just print test names immediately upon failure:
image

@DanielRosenwasser

Copy link
Copy Markdown
Member

Yes, 👍 for crazy red loading bars.

@CyrusNajmabadi

Copy link
Copy Markdown
Contributor

I'd prefer a red dot showing an error happened. Then just print the errors at the end. Having hte errors interspersed with progress info will just make investigation annoying.

@danquirk

Copy link
Copy Markdown
Member Author

The final output is unchanged either way so you will always have the errors at the end in the way you're accustomed to with today's reporters. The interspersed name would allow you to immediately note a failure and start investigating while the rest of the tests continue.

@danquirk

Copy link
Copy Markdown
Member Author

Made both of the changes in my first reply.

danquirk added a commit that referenced this pull request Jul 14, 2015
@danquirk danquirk merged commit 649e40b into master Jul 14, 2015
@danquirk danquirk deleted the newMochaReporters branch July 14, 2015 02:02
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.