Fix newline issues when adding multiple imports#38119
Merged
Merged
Fix newline issues when adding multiple imports#38119
Conversation
jessetrinity
approved these changes
Apr 22, 2020
jessetrinity
left a comment
Contributor
There was a problem hiding this comment.
The behavior in VS looks good to me.
amcasey
approved these changes
Apr 23, 2020
amcasey
left a comment
Member
There was a problem hiding this comment.
Looks correct, but I had some stylistic comments.
andrewbranch
commented
Apr 23, 2020
| */ | ||
| export function combine<T>(xs: T | readonly T[] | undefined, ys: T | readonly T[] | undefined): T | readonly T[] | undefined; | ||
| export function combine<T>(xs: T | T[] | undefined, ys: T | T[] | undefined): T | T[] | undefined; | ||
| export function combine<T>(xs: T | T[] | undefined, ys: T | T[] | undefined) { |
Member
Author
There was a problem hiding this comment.
I’ll give everyone until EOD to bikeshed this horribly vague name.
sheetalkamat
approved these changes
Apr 23, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The logic in
TextChangesfor determining whether statements added to the top of a file need newlines before and after doesn’t really work when there are already other pending insertions at the top of the file. Instead of callinginsertNodeAtTopOfFilefor each import added, just call it once with an array of all the imports to be added.Fixes #38082