Error on missing BigInt in es2020#37899
Merged
sandersn merged 2 commits intoApr 13, 2020
mastermicrosoft/TypeScript:masterfrom
error-on-missing-BigInt-in-es2020microsoft/TypeScript:error-on-missing-BigInt-in-es2020Copy head branch name to clipboard
Merged
Error on missing BigInt in es2020#37899sandersn merged 2 commits intomastermicrosoft/TypeScript:masterfrom error-on-missing-BigInt-in-es2020microsoft/TypeScript:error-on-missing-BigInt-in-es2020Copy head branch name to clipboard
sandersn merged 2 commits into
mastermicrosoft/TypeScript:masterfrom
error-on-missing-BigInt-in-es2020microsoft/TypeScript:error-on-missing-BigInt-in-es2020Copy head branch name to clipboard
Conversation
Previously it was only on ESNext, but bigint ships in ES 2020. There are no tests for this; passing `false` doesn't cause any tests to fail at least.
sheetalkamat
approved these changes
Apr 10, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously it was only an error in ESNext, but bigint is part of ES2020 so it should error there too.
I also added tests since there were none before.