Retain imports in declaration emit if they augment an export of the importing file#37820
Merged
weswigham merged 3 commits intoApr 13, 2020
microsoft:mastermicrosoft/TypeScript:masterfrom
weswigham:retain-imports-if-they-add-augmentationsweswigham/TypeScript:retain-imports-if-they-add-augmentationsCopy head branch name to clipboard
Merged
Retain imports in declaration emit if they augment an export of the importing file#37820weswigham merged 3 commits intomicrosoft:mastermicrosoft/TypeScript:masterfrom weswigham:retain-imports-if-they-add-augmentationsweswigham/TypeScript:retain-imports-if-they-add-augmentationsCopy head branch name to clipboard
weswigham merged 3 commits into
microsoft:mastermicrosoft/TypeScript:masterfrom
weswigham:retain-imports-if-they-add-augmentationsweswigham/TypeScript:retain-imports-if-they-add-augmentationsCopy head branch name to clipboard
Conversation
Member
|
It would be nice to know how many projects have augmentations coming directly from dependencies vs transitive dependencies. But I can't think of an easy way to estimate that. |
Member
Author
|
When it comes to preserving something already in the declaration file vs injecting something from the aether, I'm also just much more comfortable preserving the existing thing. |
Member
|
Agree! |
sandersn
approved these changes
Apr 8, 2020
sandersn
left a comment
Member
There was a problem hiding this comment.
I suggested one possible speedup, but I'm not sure it's valid.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #32298
Technically this won't fix all possible augmentation-including scenarios, namely this will only capture augmentations of direct dependencies; augmentations provided by transitive dependencies are a whole other bag of problems. But I'm wondering if we actually need to preemptively fix that or not; in such scenarios we'd probably need to generate and add
referencedirectives, which could be much more undesirable than the simple preservation of an existing import.