Handle comment directives in incremental parsing#37632
Merged
Merged
Handle comment directives in incremental parsing#37632
Conversation
…mental parsing Testcase for #37536
andrewbranch
approved these changes
Mar 27, 2020
Comment on lines
+7860
to
+7865
| if (!commentDirectives) { | ||
| commentDirectives = newDirectives; | ||
| } | ||
| else if (newDirectives) { | ||
| commentDirectives.push(...newDirectives); | ||
| } |
Member
There was a problem hiding this comment.
I think concatenate in core can handle this in a single call, similarly to append
Member
Author
There was a problem hiding this comment.
That one creates new array if both arrays are !undefined which is what this avoids since anyways we already have new array
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #37536