Add test for #35011#37312
Add test for #35011#37312amcasey merged 4 commits intomicrosoft:mastermicrosoft/TypeScript:masterfrom amcasey:TestNodeModulesDefaultProjectamcasey/TypeScript:TestNodeModulesDefaultProjectCopy head branch name to clipboard
Conversation
When searching for a default configured project, stop at `node_modules`.
| @@ -0,0 +1,43 @@ | ||
| namespace ts { | ||
| describe("unittests:: services:: projectService", () => { |
There was a problem hiding this comment.
This needs to go into unittests/tsserver/projects.ts instead..
There was a problem hiding this comment.
I'm happy to move it, but I don't understand why - this doesn't seem to be a server test?
There was a problem hiding this comment.
Done. I see that the corresponding product code is in the server folder, but I still don't understand why the language service is in "services" but the project service is in "server".
There was a problem hiding this comment.
projectService handles projects, hence is in server and not in language service folder
There was a problem hiding this comment.
Why are projects specific to the server?
|
@amcasey I think this is ready to go, right? |
|
@sandersn I think I just missed the sign-off notification. |
When searching for a default configured project, stop at
node_modules.