Fix contextually typed object literal completions where the object being edited affects its own inference#36556
Merged
Merged
Fix contextually typed object literal completions where the object being edited affects its own inference#36556
Conversation
weswigham
reviewed
Jan 31, 2020
weswigham
reviewed
Jan 31, 2020
weswigham
reviewed
Jan 31, 2020
weswigham
reviewed
Jan 31, 2020
weswigham
approved these changes
Jan 31, 2020
weswigham
left a comment
Member
There was a problem hiding this comment.
Approve with nits mentioned above, but since I'm a partial author you should get another set of eyes to look over it, too~
sandersn
approved these changes
Jan 31, 2020
sandersn
left a comment
Member
There was a problem hiding this comment.
I'm a little leery of the complexity of this change right at the end of the beta.
But @weswigham argues that we remove some scary complexity from contextual typing and push it right to the edge the checker's API.
Co-Authored-By: Wesley Wigham <wwigham@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is Wes’s alternative to my PR #36364, which fixes #35702.