Completions for asserts and declare#36355
Merged
sandersn merged 2 commits intoJan 22, 2020
mastermicrosoft/TypeScript:masterfrom
completions-for-asserts-declaremicrosoft/TypeScript:completions-for-asserts-declareCopy head branch name to clipboard
Merged
Completions for asserts and declare#36355sandersn merged 2 commits intomastermicrosoft/TypeScript:masterfrom completions-for-asserts-declaremicrosoft/TypeScript:completions-for-asserts-declareCopy head branch name to clipboard
asserts and declare#36355sandersn merged 2 commits into
mastermicrosoft/TypeScript:masterfrom
completions-for-asserts-declaremicrosoft/TypeScript:completions-for-asserts-declareCopy head branch name to clipboard
Conversation
andrewbranch
approved these changes
Jan 22, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not 100% sure that
assertsshould go intotypeKeywordsinstead of an ad-hoc addition toKeywordCompletion.TypeKeywordsingetTypescriptKeywordCompletions. But this makes the tests easier to update, which is a good sign that it's more predictable for users as well.Fixes #35187