forceConsistentCasingInFileNames affects module resolution#36334
Merged
sheetalkamat merged 1 commit intoJan 21, 2020
microsoft:mastermicrosoft/TypeScript:masterfrom
ajafff:forceConsistentCasingInFileNames-affectsModuleResolutionajafff/TypeScript:forceConsistentCasingInFileNames-affectsModuleResolutionCopy head branch name to clipboard
Merged
forceConsistentCasingInFileNames affects module resolution#36334sheetalkamat merged 1 commit intomicrosoft:mastermicrosoft/TypeScript:masterfrom ajafff:forceConsistentCasingInFileNames-affectsModuleResolutionajafff/TypeScript:forceConsistentCasingInFileNames-affectsModuleResolutionCopy head branch name to clipboard
sheetalkamat merged 1 commit into
microsoft:mastermicrosoft/TypeScript:masterfrom
ajafff:forceConsistentCasingInFileNames-affectsModuleResolutionajafff/TypeScript:forceConsistentCasingInFileNames-affectsModuleResolutionCopy head branch name to clipboard
Conversation
Member
|
Does it? It definitely affects diagnostics, but does it actually change our resolution process? |
Contributor
Author
|
Actually it doesn't affect resolution, it only affects semantic diagnostics. |
Member
|
Maybe we should just rename the flag - though, I guess diagnostics are part of the resolution process? @sheetalkamat can give better guidance here, though leaving a comment is cheap and worthwhile. |
Member
|
I think we do want to do module resolution again to ensure the correct file names are picked up so |
sheetalkamat
approved these changes
Jan 21, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.