Actually use the more complete update function in visitEachChild#35301
Merged
weswigham merged 1 commit intoNov 22, 2019
microsoft:mastermicrosoft/TypeScript:masterfrom
weswigham:fix-transform-assignment-assertions-moreweswigham/TypeScript:fix-transform-assignment-assertions-moreCopy head branch name to clipboard
Merged
Actually use the more complete update function in visitEachChild#35301weswigham merged 1 commit intomicrosoft:mastermicrosoft/TypeScript:masterfrom weswigham:fix-transform-assignment-assertions-moreweswigham/TypeScript:fix-transform-assignment-assertions-moreCopy head branch name to clipboard
weswigham merged 1 commit into
microsoft:mastermicrosoft/TypeScript:masterfrom
weswigham:fix-transform-assignment-assertions-moreweswigham/TypeScript:fix-transform-assignment-assertions-moreCopy head branch name to clipboard
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#35270 was slightly incomplete - it made individual
updatefunctions work, but because I forgot to updatevisitEachChild, the assignment assertion token would fail to percolate up a transformed tree.