Fix printing and emit for definite assignment assertions#35095
Merged
weswigham merged 2 commits intoNov 21, 2019
microsoft:mastermicrosoft/TypeScript:masterfrom
weswigham:fix-assignment-assertion-emitweswigham/TypeScript:fix-assignment-assertion-emitCopy head branch name to clipboard
Merged
Fix printing and emit for definite assignment assertions#35095weswigham merged 2 commits intomicrosoft:mastermicrosoft/TypeScript:masterfrom weswigham:fix-assignment-assertion-emitweswigham/TypeScript:fix-assignment-assertion-emitCopy head branch name to clipboard
weswigham merged 2 commits into
microsoft:mastermicrosoft/TypeScript:masterfrom
weswigham:fix-assignment-assertion-emitweswigham/TypeScript:fix-assignment-assertion-emitCopy head branch name to clipboard
Conversation
ajafff
reviewed
Nov 14, 2019
|
|
||
| // Type annotations are TypeScript syntax. | ||
| if (node.type) { | ||
| if (node.type || node.exclamationToken) { |
Contributor
There was a problem hiding this comment.
is this change related to the emitter?
If so, you probably also want to make the same change in computePropertyDeclaration (see #35097 which I erroneously opened)
rbuckton
approved these changes
Nov 21, 2019
jablko
pushed a commit
to jablko/TypeScript
that referenced
this pull request
Nov 21, 2019
…5095) * Fix printing and emit for definite assignment assertions * Make factories that handle definite assertions internal
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #35093
We use definite assignment assertions in our own codebase, so the referenced bug is actually blocking me doing source to source transforms on our real codebase.